-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize payments vertically #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some tiny comments but looks good to me! Nothing else we can pull from some other parts of the code? Some operations, or react compnoent, that would be better suited to be here? If not, great, let's merge! I approved.
│ ├── auth/ # All auth-related pages/components and logic. | ||
│ ├── file-upload/ # Logic for uploading files to S3. | ||
│ └── .waspignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dropped .waspignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waspignore (Was Pig Nore) is in the main src
dir, but I didn't think it was important enough to highlight in the docs here. WDYT?
@@ -61,16 +61,16 @@ If you are using a version of the OpenSaaS template with Wasp `v0.11.x` or below | |||
├── src/ # Your code goes here. | |||
│ ├── client/ # Your client code (React) goes here. | |||
│ ├── server/ # Your server code (NodeJS) goes here. | |||
│ ├── shared/ # Your shared (runtime independent) code goes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing left in shared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. nada. The leftovers got moved to common
I believe
template/app/main.wasp
Outdated
entities: [User] | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah what is with these headers now that we don't have stuff grouped by their type (actions, queries, apis, ...)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we scrap them. The docs do a pretty good job of discussing this I think. I will add links to the relevant Wasp docs in the guided tour for each section of the Wasp file.
@vinny I just noticed you haven't moved CHeckout Page, how is that? Is that on purpose? |
@Martinsos whoops, forgot to move the CheckoutPage. Thanks for the heads up! |
Implements a part of #149.