Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary rexml dependency from gemspec #66

Closed
wants to merge 1 commit into from

Conversation

mfittko
Copy link
Contributor

@mfittko mfittko commented Jan 2, 2024

Remove unnecessary rexml dependency from gemspec as it's in ruby's standard gems since 3.0, e.g. https://ruby-doc.org/3.0.6/gems/rexml/REXML.html

We're trying to limit adding unnecessary gem dependencies and since you don't have ruby < 3 any more in your build matrix, I'd suggest to remove it from the dependencies again.

@mfittko
Copy link
Contributor Author

mfittko commented Jan 2, 2024

I know this has been added explicitly in #56 - but this was before 2.7 was removed form the build matrix in #64 @wata727

@wata727
Copy link
Owner

wata727 commented Jan 3, 2024

Thank you for your contribution. But the CI seems to be failing.
https://github.com/wata727/elastic_whenever/actions/runs/7394432951/job/20115799744?pr=67

My understanding is that this dependency is required for Ruby 3.0+, and 2.7 support is not relevant. Since 3.0, rexml is no longer the default gem but a bundled gem, so an explicit dependency is required when using it via Bundler.

@mfittko
Copy link
Contributor Author

mfittko commented Jan 3, 2024

oh now I get it, sorry but we were never having an issue with it because we normally have nokogiri in our projects. let me dig a bit but, I might just close this then. sorry!

@mfittko mfittko closed this Jan 3, 2024
@mfittko mfittko deleted the remove-rexml-dependency branch January 3, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants