Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo support (reopen of #53) #54

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Undo support (reopen of #53) #54

wants to merge 9 commits into from

Conversation

shaiay
Copy link

@shaiay shaiay commented May 11, 2015

re-opening of pull request #53 which was inadvenrtantly deleted by me. I just wanted to rename my branch ....

Original test from #53:
After some frustrating silly deaths I decided to add an undo function. I takes you back 10 steps, and will also work when you're dead.
I know there is a small chance of it being acepted with it being against the whole roguelike idea, but just in case, I tried to make it as easy as posible to merge.

It works by saving the game/level on hero.idle() to a size 10 FIFO buffer which is written to using a ByteArrayStream.
When requesting undo the game & level are reaf back from the first (oldest) FIFO elemet.

Shai

@shaiay shaiay mentioned this pull request May 11, 2015
@sylvia43
Copy link

This is really neat. Could you tag a release with an APK in your fork?

@shaiay
Copy link
Author

shaiay commented May 11, 2015

I might just publish on the playstore, although I'd rather have it accepted
to pixel dungeon proper

On Mon, May 11, 2015, 22:10 Shreyas [email protected] wrote:

This is really neat. Could you tag a release with an APK in your fork?


Reply to this email directly or view it on GitHub
#54 (comment).

@sylvia43
Copy link

I mean it might get rejected as it really breaks the roguelike aspects of the game...

Regardless, it'd be cool if you had a release on your fork. I'd love to play and contribute to this.

@00-Evan
Copy link

00-Evan commented May 14, 2015

@shaiay

Watabou does not accept or even really aknowledge pull requests, and this violates the roguelike nature of the game, so the chance of this getting merged is basically 0.

It's a neat idea though.

@shaiay
Copy link
Author

shaiay commented Jul 14, 2015

The patched version is available on the android play-store:
undone Pixel Dungeon

Let me know what you think

@sylvia43
Copy link

Will definitely take a look tonight. Looks pretty sweet. How far back does it go?

@shaiay
Copy link
Author

shaiay commented Jul 14, 2015

It goes back 10 turns

On Tue, Jul 14, 2015, 16:26 Shreyas [email protected] wrote:

Will definitely take a look tonight. Looks pretty sweet. How far back does
it go?


Reply to this email directly or view it on GitHub
#54 (comment).

@sylvia43
Copy link

What I meant is can you undo multiple times?

@shaiay
Copy link
Author

shaiay commented Jul 14, 2015

I just keep a list of the last 10 steps,, and undo will go to the oldest
step on that lust, so the answer is Yes, you can undo multiple times, but
never go back further than 10 steps than the first time you undo

On Tue, Jul 14, 2015, 18:11 Shreyas [email protected] wrote:

What I meant is can you undo multiple times?


Reply to this email directly or view it on GitHub
#54 (comment).

Shai Ayal added 4 commits August 28, 2015 23:46
# Conflicts:
#	src/com/watabou/pixeldungeon/Dungeon.java
#	src/com/watabou/pixeldungeon/scenes/InterlevelScene.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants