Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dodanie modala potwierdzenia dla wszystkich resouców + podbicie wersj… #1017

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Dodanie modala potwierdzenia dla wszystkich resouców + podbicie wersj… #1017

wants to merge 1 commit into from

Conversation

MichalKarol
Copy link
Collaborator

…i antd

@MichalKarol MichalKarol requested review from ad-m and fervero July 26, 2021 23:48
ad-m
ad-m approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@ad-m ad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Czytelna i przejrzysta zmiana 🥇

@ad-m
Copy link
Member

ad-m commented Aug 5, 2021

@fervero czy masz w zakresie tej zmiany własne uwagi?

@fervero
Copy link
Collaborator

fervero commented Aug 6, 2021

@ad-m w sumie jedną: w paru miejscach mamy konstrukcję doSomething().then(callback).catch(ten sam callback). Powinno dać się zastąpić jednym .finally(callback).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-m ad-m ad-m approved these changes

@fervero fervero Awaiting requested review from fervero

Assignees
No one assigned
Labels
front-end front-end-deps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalKarol @ad-m @fervero