Merge branch 'cwijesek/post-prod-deploy-fixes' into cwijesek/no-meeti…

…ng-dm-remind
waterloo-rocketry · Feb 26, 2024 · 778118a · 778118a
2 parents 3c7bc15 + 0684cb5
commit 778118a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/listeners/commands/helpCommand.ts b/src/listeners/commands/helpCommand.ts
@@ -5,9 +5,9 @@ import { logCommandUsed } from "../../utils/logging";
 import { postEphemeralMessage } from "../../utils/slack";
 import { SlackLogger } from "../../classes/SlackLogger";
 
-const message = `For guides on how to use minerva's functionality, check out the feature reference guides in the Google Drive (<https://drive.google.com/drive/u/1/folders/1h7FZKuF3Zvv8EygjB8pSTk2aGuHHpBtj|link>) 
-* <https://docs.google.com/document/d/1KbeJtU06Uosjpd3XlvEGtElOx5lAZz9vDe8yzHyFhvU/edit#heading=h.g3pdvke98aqf|Meeting Reminders>
-* <https://docs.google.com/document/d/1otYHtmFHzkN8g7089EGQpxi9-7C_iKFhDt2L2tuwxHs/edit#heading=h.8w6auka00s3p|Message Notifications>
+const message = `For instructions on how to use minerva's functionality, check out the feature reference guides in the Google Drive (<https://drive.google.com/drive/u/1/folders/1h7FZKuF3Zvv8EygjB8pSTk2aGuHHpBtj|link>) 
+• <https://docs.google.com/document/d/1KbeJtU06Uosjpd3XlvEGtElOx5lAZz9vDe8yzHyFhvU/edit#heading=h.g3pdvke98aqf|Meeting Reminders>
+• <https://docs.google.com/document/d/1otYHtmFHzkN8g7089EGQpxi9-7C_iKFhDt2L2tuwxHs/edit#heading=h.8w6auka00s3p|Message Notifications>
 `;
 
 /**

diff --git a/src/listeners/commands/notifyCommand.ts b/src/listeners/commands/notifyCommand.ts
@@ -100,7 +100,7 @@ export default async function notifyCommandHandler({
 
   const responseMessage = `Notified ${
     notifyType == NotifyType.DM_SINGLE_CHANNEL_GUESTS ? `${singleChannelGuestsMessaged} single-channel guests in` : ""
-  } channels ${channelSet
+  } channel(s) ${channelSet
     .values()
     .map((c) => `\`${c.name}\``)
     .join(", ")} about message \`${messageUrl}\``;
@@ -119,7 +119,9 @@ export function parseNotifyCommand(command: string): NotifyParameters {
   const tokens = command.split(" ");
 
   if (tokens.length == 1 && tokens[0].trim() == "") {
-    throw new Error("Please provide a message to send. Usage: `/notify <messageURL>`");
+    throw new Error(
+      "Please provide a message to send. Usage: `/notify LINK {copy | copy-ping} [default] [#channel1 #channel2 …]`",
+    );
   }
 
   // Check if first token is a valid URL

diff --git a/tests/unit/commands/notifyCommand.test.ts b/tests/unit/commands/notifyCommand.test.ts
@@ -139,7 +139,7 @@ describe("parseNotifyCommand", () => {
   it("throws an error when the command is empty", () => {
     const commandArgs = "";
     expect(() => parseNotifyCommand(commandArgs)).toThrow(
-      "Please provide a message to send. Usage: `/notify <messageURL>`",
+      "Please provide a message to send. Usage: `/notify LINK {copy | copy-ping} [default] [#channel1 #channel2 …]`",
     );
   });