Add @channel ping to reminder message for only five-minute reminders

waterloo-rocketry · Jan 10, 2024 · 8f58292 · 8f58292
1 parent a770d26
commit 8f58292
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/utils/eventReminders.ts b/src/utils/eventReminders.ts
@@ -125,7 +125,9 @@ export function remindUpcomingEvents(events: CalendarEvent[], client: WebClient)
  * @returns The generated reminder text
  */
 export function generateEventReminderText(event: CalendarEvent, reminderType: EventReminderType): string {
-  let message = `<!channel>\nReminder: *${event.title}* is occurring`;
+  let message = `${reminderType == EventReminderType.FIVE_MINUTES ? "<!channel>\n" : ""}Reminder: *${
+    event.title
+  }* is occurring`;
 
   if (reminderType === EventReminderType.FIVE_MINUTES) {
     const timeUntilEvent = event.start.getTime() - new Date().getTime();

diff --git a/tests/unit/utils/meetingReminders.test.ts b/tests/unit/utils/meetingReminders.test.ts
@@ -168,7 +168,8 @@ Ways to attend:
       const result = generateEventReminderText(event, EventReminderType.FIVE_MINUTES);
 
       expect(result).toBe(
-        `Reminder: *Test event* is occurring in *5 minutes*
+        `<!channel>
+Reminder: *Test event* is occurring in *5 minutes*
 <https://www.google.com/calendar/event?eid=MGJyczFiMjJuZHJjZzRnZmx0Z2c1OGRocmkgdXdhdGVybG9vLnJvY2tldHJ5LmRxxxxx|Event Details>
 Ways to attend:
 \t:office: In person @ Test location
@@ -199,7 +200,8 @@ Ways to attend:
       const result = generateEventReminderText(event, EventReminderType.FIVE_MINUTES);
 
       expect(result).toBe(
-        `Reminder: *Test event* is occurring in *5 minutes*
+        `<!channel>
+Reminder: *Test event* is occurring in *5 minutes*
 <https://www.google.com/calendar/event?eid=MGJyczFiMjJuZHJjZzRnZmx0Z2c1OGRocmkgdXdhdGVybG9vLnJvY2tldHJ5LmRxxxxx|Event Details>
 Ways to attend:
 \t:globe_with_meridians: Online @ https://meet.waterloorocketry.com/bay_area`,
@@ -232,7 +234,8 @@ Ways to attend:
       const result = generateEventReminderText(event, EventReminderType.FIVE_MINUTES);
 
       expect(result).toBe(
-        `Reminder: *Test event* is occurring in *5 minutes*
+        `<!channel>
+Reminder: *Test event* is occurring in *5 minutes*
 <https://www.google.com/calendar/event?eid=MGJyczFiMjJuZHJjZzRnZmx0Z2c1OGRocmkgdXdhdGVybG9vLnJvY2tldHJ5LmRxxxxx|Event Details>
 Ways to attend:
 \t:office: In person @ Test location
@@ -265,7 +268,8 @@ Ways to attend:
       const result = generateEventReminderText(event, EventReminderType.FIVE_MINUTES);
 
       expect(result).toBe(
-        `Reminder: *Test event* is occurring in *5 minutes*
+        `<!channel>
+Reminder: *Test event* is occurring in *5 minutes*
 <https://www.google.com/calendar/event?eid=MGJyczFiMjJuZHJjZzRnZmx0Z2c1OGRocmkgdXdhdGVybG9vLnJvY2tldHJ5LmRxxxxx|Event Details>
 Ways to attend:
 \t:globe_with_meridians: Online @ https://example.com`,