-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement /meeting-reminder
command
#67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumManiac
changed the title
Cwijesek/22 manual meeting reminder
Implement Feb 7, 2024
/meeting-reminder
command
QuantumManiac
temporarily deployed
to
development
February 11, 2024 20:39
— with
GitHub Actions
Inactive
QuantumManiac
requested review from
PCModeActivate,
slightlyskepticalpotat,
yxyyeah,
Panizghi,
billyao021031 and
shirleyfyx
as code owners
February 11, 2024 20:39
QuantumManiac
requested review from
jeffrey-huang-yz,
wxp02 and
a team
as code owners
February 11, 2024 20:39
QuantumManiac
temporarily deployed
to
development
February 13, 2024 16:58
— with
GitHub Actions
Inactive
shirleyfyx
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @slightlyskepticalpotat, @wxp02, and @yxyyeah)
QuantumManiac
temporarily deployed
to
development
February 23, 2024 00:17
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
/meeting-reminder
command, formerly known as/meeting reminder
. This allows users to trigger a reminder for the soonest upcoming event in the channel that it was executed in. In addition, executing/meeting-reminder ping
not only triggers a reminder, but also pings@channel
.This PR closes #22.
Developer Testing
Testing done:
generateEventReminderChannelText
to handle the manually triggered casesReviewer Testing
Steps to view/test
/meeting-reminder
command in a channel that does not have any upcoming events in the next 24 hours and ensure that you get a message stating such/meeting-reminder
command in a channel that has an upcoming event and ensure that a reminder message is sent/meeting-reminder ping
command in a channel that has an upcoming event and ensure that a reminder message is sent and it contains and it pings@channel
This change is