Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /meeting-reminder command #67

Merged
merged 22 commits into from
Feb 23, 2024

Conversation

QuantumManiac
Copy link
Member

@QuantumManiac QuantumManiac commented Feb 7, 2024

Description

This PR implements the /meeting-reminder command, formerly known as /meeting reminder. This allows users to trigger a reminder for the soonest upcoming event in the channel that it was executed in. In addition, executing /meeting-reminder ping not only triggers a reminder, but also pings @channel.

This PR closes #22.

Developer Testing

Testing done:

  • Updated unit tests for generateEventReminderChannelText to handle the manually triggered cases
  • Tested functionality on the dev slack, including its handling of error cases when trying to run the command in channels where minerva does not exist.

Reviewer Testing

Steps to view/test

  1. Run the /meeting-reminder command in a channel that does not have any upcoming events in the next 24 hours and ensure that you get a message stating such
  2. Run the /meeting-reminder command in a channel that has an upcoming event and ensure that a reminder message is sent
  3. Run the /meeting-reminder ping command in a channel that has an upcoming event and ensure that a reminder message is sent and it contains and it pings @channel

This change is Reviewable

@QuantumManiac QuantumManiac self-assigned this Feb 7, 2024
@QuantumManiac QuantumManiac changed the title Cwijesek/22 manual meeting reminder Implement /meeting-reminder command Feb 7, 2024
Copy link
Contributor

@shirleyfyx shirleyfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @slightlyskepticalpotat, @wxp02, and @yxyyeah)

@QuantumManiac QuantumManiac merged commit 78fe2ab into main Feb 23, 2024
2 of 3 checks passed
@QuantumManiac QuantumManiac deleted the cwijesek/22-manual-meeting-reminder branch February 23, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual Meeting Reminders (/meeting reminder)
2 participants