Fix issue with single-channel guests not being identified #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumManiac
requested review from
PCModeActivate,
slightlyskepticalpotat,
yxyyeah,
Panizghi,
billyao021031,
shirleyfyx,
jeffrey-huang-yz,
wxp02 and
a team
as code owners
QuantumManiac
temporarily deployed
to
development
GitHub Actions
Inactive
wxp02
approved these changes
Mar 3, 2024
shirleyfyx
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @slightlyskepticalpotat, and @yxyyeah)
QuantumManiac
temporarily deployed
to
development
GitHub Actions
Inactive
QuantumManiac
deleted the
cwijesek/fix-single-channel-guest-identification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug with the
determineUserTypefunction that made it such that single channel guests were not properly identified in the production slack workspace. This was not picked up in the development environment as single-channel guests did not exist and therefore we were using admin and owner users as stand-ins.Developer Testing
Testing done:
This change is