Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when adding multiple reactions to six-hour reminder message #74

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

QuantumManiac
Copy link
Member

@QuantumManiac QuantumManiac commented Mar 2, 2024

Description

Fixed an issue where "react if coming or not" reaction emojis on six-hour reminder messages would not be added to the message in the right order. This was caused by the two calls to addReactionToMessage being too close to each other and therefore resulting in a race condition. Fix is to add a small manual delay in between.

Developer Testing

Testing done:

  • Manually tested on the development slack workspace

Reviewer Testing

  • N/A

This change is Reviewable

@QuantumManiac QuantumManiac changed the title Cwijesek/fix async reaction add Fix race condition when adding multiple reactions to six-hour reminder message Mar 2, 2024
@QuantumManiac QuantumManiac marked this pull request as ready for review March 2, 2024 14:55
@QuantumManiac QuantumManiac added the bug Something isn't working label Mar 3, 2024
Copy link

@Darth-Raazi Darth-Raazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @shirleyfyx, @slightlyskepticalpotat, and @yxyyeah)

Copy link
Contributor

@shirleyfyx shirleyfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @slightlyskepticalpotat, and @yxyyeah)

@QuantumManiac QuantumManiac merged commit 8e4f144 into main Mar 6, 2024
3 checks passed
@QuantumManiac QuantumManiac deleted the cwijesek/fix-async-reaction-add branch March 6, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants