Update README #79
Merged
Update README #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirleyfyx
requested review from
QuantumManiac,
PCModeActivate,
slightlyskepticalpotat,
yxyyeah,
Panizghi,
billyao021031,
jeffrey-huang-yz,
wxp02 and
a team
as code owners
ManavToor
approved these changes
Apr 17, 2024
QuantumManiac
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
LGTM! Just one nit if you would like to take care of it.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @billyao021031, @jeffrey-huang-yz, @Panizghi, @PCModeActivate, @shirleyfyx, @slightlyskepticalpotat, @wxp02, and @yxyyeah)
README.md line 24 at r1 (raw file):
For detailed instructions on how to onboard and develop Minerva, refer to the following guides: - [Minerva Developer Onboarding Guide](https://docs.google.com/document/d/1Ln9ldKIFPOmMxLfW3iFzAfW-HCECqbwqHC7oJxRYEqo/edit#heading=h.140h72nwd7xz) - [Minerva Developer Reference Guide](https://docs.google.com/document/d/1vz9b3J8ghjsyqJtUuTTT1KHH7F9GhhCrGC5Nmy-X3rQ/edit#heading=h.groaoi1xvvzs).
Nit
Suggestion:
- [Minerva Developer Reference Guide](https://docs.google.com/document/d/1vz9b3J8ghjsyqJtUuTTT1KHH7F9GhhCrGC5Nmy-X3rQ/edit#heading=h.groaoi1xvvzs)
QuantumManiac
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Readme and include updated onboarding and features documents.
This PR closes #10.
This change is