K8po/monit 43152 templatize pixie namespace #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se causes errors as controller manager when deployed in a custom namespace tries to delete all resources atm.We currently do allow deploying k8s operator in a custom namespace which gives redundant logs for pixie eventhough it is experimental and turned OFF by default. This is the reason we went with this solution instead of modifying controller manager code to delete only enabled resources.
oppegard
approved these changes
May 13, 2024
oppegard
approved these changes
May 13, 2024
This reverts commit 532149e.
akodali18
added a commit
that referenced
this pull request
May 24, 2024
* Fix generate_yamls to templatize namespace for Pixie CR. This otherwise produces noisy error logs in controller manager when deployed in a custom namespace as it tries to delete all the components. -------- (cherry picked from commit 71e741c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the operator is deployed on a custom namespace, the controller manager tries to delete secrets that pertain to pixie from the default namespace irrespective of whether pixie experimental features are ON/OFF, thus producing noisy logs that consume cost/resources and noisy alerts for the customer.