Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stepaction param default value referencing other param #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

waveywaves
Copy link
Owner

  • multipass default value substitution: one for non referenced default values, another one for parameter references in default values
  • add validation to ensure parameters referenced in default values are defined before use
  • substitute default values of parameters with referenced parameter values if necessary
  • update replacementsFromStepResults to only process step result references
  • add comments which highlight order of hydration of parameters
  • add tests for replacementsFromStepResults, validateDefaultParameterReferences
  • add example for parameter references in default values of step action parameters

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

- multipass default value substitution: one for non referenced default values,
another one for parameter references in default values
- add validation to ensure parameters referenced in default values are defined
  before use
- substitute default values of parameters with referenced parameter values if necessary
- update replacementsFromStepResults to only process step result references
- add comments which highlight order of hydration of parameters
- add tests for replacementsFromStepResults, validateDefaultParameterReferences
- add example for parameter references in default values of step action parameters

Signed-off-by: Vibhav Bobade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant