Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wp_viewporter protocol #80

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Implement wp_viewporter protocol #80

merged 2 commits into from
Mar 5, 2025

Conversation

maxhbooth
Copy link
Contributor

No description provided.

@maxhbooth
Copy link
Contributor Author

I opted to remove the Eq requirement from SurfaceState, but if you still prefer trying to use that fixed crate in #71 lmk. But I would argue that since we already have a ton of f64 geometry in other messages it doesn't really make sense to treat this differently.

@maxhbooth maxhbooth requested a review from nicolasavru March 4, 2025 23:55
nicolasavru
nicolasavru requested changes Mar 5, 2025
View reviewed changes
@maxhbooth maxhbooth force-pushed the feature/wp-viewporter branch from 5c6826e to 228be01 Compare March 5, 2025 15:52
@maxhbooth maxhbooth requested a review from nicolasavru March 5, 2025 15:52
@maxhbooth maxhbooth force-pushed the feature/wp-viewporter branch from 228be01 to 7f7877b Compare March 5, 2025 15:58
@maxhbooth maxhbooth force-pushed the feature/wp-viewporter branch from 7f7877b to de28336 Compare March 5, 2025 16:00
@maxhbooth maxhbooth merged commit 6e20ffd into master Mar 5, 2025
11 checks passed
@maxhbooth maxhbooth deleted the feature/wp-viewporter branch March 5, 2025 16:13
@maxhbooth maxhbooth mentioned this pull request Mar 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasavru nicolasavru nicolasavru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxhbooth @nicolasavru