Regenerate resources sdk 🔁 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otomator
force-pushed
the
chore/regenerate
branch
from
73a2049
to
fc85679
Compare
Disabled the testing on python 3.9 because of a python reflection issue in the pydantic typeadapter, where forward compatibility of `|` union types seems to break:
```
../api/tasks_batch_operations_api_test.py:120:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../types/batch_task_spec_stub.py:76: in create_instance
return BatchTaskSpecAdapter.validate_python(
../../3.9-types/lib/python3.9/site-packages/pydantic/type_adapter.py:135: in wrapped
return func(self, *args, **kwargs)
../../3.9-types/lib/python3.9/site-packages/pydantic/type_adapter.py:366: in validate_python
return self.validator.validate_python(object, strict=strict, from_attributes=from_attributes, context=context)
../../3.9-types/lib/python3.9/site-packages/waylay/sdk/api/_models.py:81: in _model_validator
return handler(value)
../../3.9-types/lib/python3.9/site-packages/waylay/sdk/api/_models.py:135: in _field_validator
field_type = get_type_hints(cls).get(info.field_name, Any)
/opt/homebrew/Caskroom/miniconda/base/envs/waylay-sdk-3.9/lib/python3.9/typing.py:1459: in get_type_hints
value = _eval_type(value, base_globals, localns)
/opt/homebrew/Caskroom/miniconda/base/envs/waylay-sdk-3.9/lib/python3.9/typing.py:292: in _eval_type
return t._evaluate(globalns, localns, recursive_guard)
/opt/homebrew/Caskroom/miniconda/base/envs/waylay-sdk-3.9/lib/python3.9/typing.py:554: in _evaluate
eval(self.__forward_code__, globalns, localns),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> ???
E TypeError: unsupported operand type(s) for |: 'ModelMetaclass' and 'NoneType'
```
simosho
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regenerate resources sdk from https://github.com/waylayio/waylay-py-services/commit/54e5594c06ba5cdeeee6470c336ad3f224756352