Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WP-1265] Typescript cleanup #742

Merged
merged 17 commits into from
Jan 11, 2024
Merged

[WP-1265] Typescript cleanup #742

merged 17 commits into from
Jan 11, 2024

Conversation

bogue
Copy link
Contributor

@bogue bogue commented Jan 5, 2024

Allow root imports, i.e.
import CallSession from "@wazo/sdk/lib/domain/CallSession"
becomes import { CallSession } from "@wazo/sdk"

@manuquentin
Copy link
Member

Nice work !
Have you tested if the tree shaking is working with this change ?
Does the bundle size is growing in our project using this SDK ?

@manuquentin manuquentin merged commit dc29e39 into master Jan 11, 2024
2 checks passed
@manuquentin manuquentin deleted the WP-1265-ts-cleanup branch January 11, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuquentin manuquentin manuquentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogue @manuquentin