refactor: move vulnerability detection constants to a dedicated file …

…for better organization
wazuh · Feb 12, 2025 · ae09f91 · ae09f91
1 parent 9ec4fde
commit ae09f91
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/plugins/wazuh-analysis/public/groups/threat-intelligence/applications.ts b/plugins/wazuh-analysis/public/groups/threat-intelligence/applications.ts
@@ -4,10 +4,6 @@ import {
   AppNavLinkStatus,
   AppUpdater,
 } from '../../../../../src/core/public';
-import {
-  VULNERABILITY_DETECTION_ID,
-  VULNERABILITY_DETECTION_TITLE,
-} from './constants';
 import {
   MITRE_ATTACK_ID,
   MITRE_ATTACK_TITLE,
@@ -16,6 +12,10 @@ import {
   THREAT_HUNTING_ID,
   THREAT_HUNTING_TITLE,
 } from './apps/threat-hunting/constants';
+import {
+  VULNERABILITY_DETECTION_ID,
+  VULNERABILITY_DETECTION_TITLE,
+} from './apps/vulnerability-detection/constants';
 
 export function getThreatIntelligenceApps(updater$?: Subject<AppUpdater>) {
   return [

diff --git a/...h-analysis/public/groups/threat-intelligence/apps/vulnerability-detection/application.tsx b/...h-analysis/public/groups/threat-intelligence/apps/vulnerability-detection/application.tsx
@@ -4,11 +4,9 @@ import ReactDOM from 'react-dom';
 import { ThreatIntelligenceNavGroup } from '../..';
 import { Layout } from '../../../layout';
 import { createSideNavItems } from '../../../side-nav';
-import {
-  THREAT_INTELLIGENCE_TITLE,
-  VULNERABILITY_DETECTION_ID,
-} from '../../constants';
+import { THREAT_INTELLIGENCE_TITLE } from '../../constants';
 import { VulnerabilityDetectionApp } from './vulnerability-detection-app';
+import { VULNERABILITY_DETECTION_ID } from './constants';
 
 export const renderApp = async (params: AppMountParameters) => {
   const items = createSideNavItems({

diff --git a/...azuh-analysis/public/groups/threat-intelligence/apps/vulnerability-detection/constants.ts b/...azuh-analysis/public/groups/threat-intelligence/apps/vulnerability-detection/constants.ts
@@ -0,0 +1,15 @@
+import { i18n } from '@osd/i18n';
+import { PLUGIN_ID } from '../../../../../common/constants';
+import { buildSubAppId } from '../../../../utils';
+import { THREAT_INTELLIGENCE_ID } from '../../constants';
+
+export const VULNERABILITY_DETECTION_ID = buildSubAppId(
+  THREAT_INTELLIGENCE_ID,
+  'vulnerability_detection',
+);
+export const VULNERABILITY_DETECTION_TITLE = i18n.translate(
+  `${PLUGIN_ID}.category.${VULNERABILITY_DETECTION_ID}`,
+  {
+    defaultMessage: 'Vulnerability Detection',
+  },
+);
diff --git a/...c/groups/threat-intelligence/apps/vulnerability-detection/vulnerability-detection-app.tsx b/...c/groups/threat-intelligence/apps/vulnerability-detection/vulnerability-detection-app.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 import { AppMountParameters } from 'opensearch-dashboards/public';
-import { VULNERABILITY_DETECTION_TITLE } from '../../constants';
+import { VULNERABILITY_DETECTION_TITLE } from './constants';
 
 interface VulnerabilityDetectionAppProps {
   params: AppMountParameters;

diff --git a/plugins/wazuh-analysis/public/groups/threat-intelligence/constants.ts b/plugins/wazuh-analysis/public/groups/threat-intelligence/constants.ts
@@ -1,6 +1,5 @@
 import { i18n } from '@osd/i18n';
 import { PLUGIN_ID } from '../../../common/constants';
-import { buildSubAppId } from '../../utils';
 
 export const THREAT_INTELLIGENCE_ID = 'threat_intelligence';
 export const THREAT_INTELLIGENCE_TITLE = i18n.translate(
@@ -16,13 +15,3 @@ export const THREAT_INTELLIGENCE_DESCRIPTION = i18n.translate(
       'Collect and analyze information about potential threats to inform security decisions.',
   },
 );
-export const VULNERABILITY_DETECTION_ID = buildSubAppId(
-  THREAT_INTELLIGENCE_ID,
-  'vulnerability_detection',
-);
-export const VULNERABILITY_DETECTION_TITLE = i18n.translate(
-  `${PLUGIN_ID}.category.${VULNERABILITY_DETECTION_ID}`,
-  {
-    defaultMessage: 'Vulnerability Detection',
-  },
-);