-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wazuh Analysis plugin files and structure #7242
Open
guidomodarelli
wants to merge
214
commits into
main
Choose a base branch
from
enhancement/484-create-the-analysis-plugin-and-implement-the-new-menu-app-registration-method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Wazuh Analysis plugin files and structure #7242
guidomodarelli
wants to merge
214
commits into
main
from
enhancement/484-create-the-analysis-plugin-and-implement-the-new-menu-app-registration-method
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zuh Analysis plugin
… and FIM in AnalysisPlugin
…date core start property assignment
…ax for improved context handling
…andling and simplify navigation logic
…tter organization
…tter organization
…r better organization
…for better organization
…nd-implement-the-new-menu-app-registration-method
This comment was marked as resolved.
This comment was marked as resolved.
…plicationService methods
…d navigation group definitions
…creating groups and applications
Desvelao
reviewed
Feb 14, 2025
Desvelao
reviewed
Feb 14, 2025
…te usage in plugins
…elated documentation
…for layout management
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to create the "Analysis" plugin that will contain all data analysis dashboard applications. Our primary objective is to register this plugin and its applications to establish the scaffolding for future dashboard development.
Menu structure
Functional requirements
Issues Resolved
wazuh/wazuh-dashboard#484
Evidence
Test
Test of titles in navigation groups in the sidebar
Separated static application configurations into a dedicated file to improve code organization and simplify future maintenance
Moved shared logic between different plugins to
wazuh-core
The applications under "Analysis" should only appear in that section and should not be located elsewhere or repeated.
Test the menu structure
The applications must be registered in both the legacy and new navigation menus.
The SideNav should only appear in the old menu.
Legacy menu:
![image](https://private-user-images.githubusercontent.com/38738725/412048951-490feed6-d030-41fd-8998-db55685ab664.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTg3NDIsIm5iZiI6MTczOTY5ODQ0MiwicGF0aCI6Ii8zODczODcyNS80MTIwNDg5NTEtNDkwZmVlZDYtZDAzMC00MWZkLTg5OTgtZGI1NTY4NWFiNjY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MzQwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0YWI0YTc2YzdmODZjNmFkYmNhZmZmNmQyNzMxOTdkMGQzZWJiOGU2ZDAyZDJkNGQyMTRjOTIyMDgyZDAyMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AG_qZwGrarW7W2TYtxXeK3IY61Dg1SrPGLkqEUKTUlQ)
New menu:
![image](https://private-user-images.githubusercontent.com/38738725/412049256-c2859d29-6d1f-42cf-be34-2f04f7d3dc2d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTg3NDIsIm5iZiI6MTczOTY5ODQ0MiwicGF0aCI6Ii8zODczODcyNS80MTIwNDkyNTYtYzI4NTlkMjktNmQxZi00MmNmLWJlMzQtMmYwNGY3ZDNkYzJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA5MzQwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxNmEyY2MxMzc2NTQwNTMzMzI5MGEzNDQyN2M0ZGQ5NzJjODliYTFkMGI4NTkyOWY5Mzk0ODU4ZTJiNThjMjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Aj67aXhENF1Lww-DAJUa1q09vppYemgGGJt9SPR_75w)
The applications must be registered in search command
Check List
Update 2025/02/14
I will make the following changes based on @Desvelao’s review:
Currently, some elements—such as the
Layout
component, which renders the plugin’s internal sidebar when group navigation (new menu) is disabled, and utility functions likecreateSideNavItems
—would need to be replicated in each plugin individually.To avoid this duplication, I will evaluate whether these elements can:
This will improve maintainability and reduce code redundancy across plugins.
Solved here ff4a1a3, 5b00e82
Solving these comments
Adding in comments in which commit it was resolved