Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EasyCommit #8861

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add EasyCommit #8861

merged 2 commits into from
Mar 28, 2024

Conversation

educbraga
Copy link
Contributor

@educbraga educbraga commented Jan 3, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package simplifies the process of making Git commits. After pressing a single key binding the plugin performs a series of Git operations: fetch, pull, and add all or add the current file. After staging changes, it prompts for a commit message. It commits with the provided message and then pushes the changes to the remote repository on the current branch.

In case of any issues during the Git operations it stops and displays the error messages. Allows cancelling the commit process by pressing ESC. It provides ongoing feedback in the Sublime Text status bar, keeping the user informed at every step.

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: EasyCommit

Packages added:
  - EasyCommit

Processing package "EasyCommit"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Thanks for your submission and sorry for taking a while to review it.

Looks really nice and useful 👍🏻 Some remarks:

  • The commands are not exposed via the command palette. Especially for new users that makes them hard to find (it's only after seeing the package does nothing, then finding the README, that you figure out it needs more setup). Key bindings are nice if you can remember them, but they should never be the only way to trigger commands.
  • You have quite a bit of code duplication going on here. Getting that cleaned up will help you maintain it and others contribute to it over time.

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Mar 27, 2024
@braver
Copy link
Collaborator

braver commented Mar 27, 2024

Please respond to the feedback to continue the review.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: EasyCommit

Packages added:
  - EasyCommit

Processing package "EasyCommit"
  - All checks passed

@braver braver merged commit c6428ab into wbond:master Mar 28, 2024
2 checks passed
@educbraga
Copy link
Contributor Author

Please respond to the feedback to continue the review.

Thank you for the reminder @braver!
I made some changes based on your suggestions.

If there is any other one, just let me know! 😄✌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided stale The pull request needs to be updated but has not been within the recent past (2 weeks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants