Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial submission for Signet Bookmarks #8977

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

cepthomas
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

ST's built-in bookmark system is commonly known to be deficient. There are several packages
that claim to improve on it but those I've used tend to be over-featured and/or brittle.
e.g. https://packagecontrol.io/packages/Better%20Bookmarks which is over-complicated
and hasn't been updated in 6 years.

  • The basics toggle/next/previous/clear.
  • Persisted per ST project.
  • Option to traverse just the current file or all files in project.

This is one of several plugins I'm submitting to Package Control for consideration. I've been
refining them for several years and use them daily. I think they could be useful to others, in whole or as parts.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Signet Bookmarks

Packages added:
  - Signet Bookmarks

Processing package "Signet Bookmarks"
  - All checks passed

@cepthomas
Copy link
Contributor Author

It's been almost two months. If there's something I've missed in my submissions (five), please advise. Otherwise carry on.

repository/s.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Nov 19, 2024

I appreciate you didn't add entries to the context menu. Adding a Main menu entry with some child items would be totally fine though. That's less "contested space".

// Scope name for gutter icon color.
"scope": "keyword",

Could be a good use case for the colorish scopes

I would like to be able to toggle signets etc from the command palette though?

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Signet Bookmarks

Packages added:
  - Signet Bookmarks

Processing package "Signet Bookmarks"
  - All checks passed

@cepthomas
Copy link
Contributor Author

I appreciate you didn't add entries to the context menu. Adding a Main menu entry with some child items would be totally fine though. That's less "contested space".

It's so annoying to have a plugin clog up the context menus. There's a certain sidebar plugin...

// Scope name for gutter icon color.
"scope": "keyword",

Could be a good use case for the colorish scopes

They are supported already. I have made region.redish the default so should be more obvious.

I would like to be able to toggle signets etc from the command palette though?

OK., added. I never use the palette so tend to overlook. I don't see its value except for a few things that are clumsy from the context menu and key bindings. But that's me.

@braver
Copy link
Collaborator

braver commented Nov 22, 2024

There's a certain sidebar plugin...

Hah, wouldn't know what you're talking about there 😉

@braver braver merged commit 3cb401f into wbond:master Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants