adds codemp plugin package

[ghyatzo]

• I'm the package's author and/or maintainer.
• I have have read the docs.
• I have tagged a release with a semver version number.
• My package repo has a description and a README describing what it's for and how to use it.
• My package doesn't add context menu entries. *
• My package doesn't add key bindings. **
• Any commands are available via the command palette.
• Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
• If my package is a syntax it doesn't also add a color scheme. ***
• If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
• I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is the plugin for the codemp library for remote collaborative editing.

There are no packages like it in Package Control.

[ghyatzo]

@packagecontrol-bot

[packagecontrol-bot]

Automated testing result: SUCCESS

Repo link: Codemp

Packages added:
  - Codemp

Processing package "Codemp"
  - All checks passed

[braver]

Thanks for your submission. I'm not going to test through the entirety of your package 😅 Overall it looks well considered. Just some general remarks:

• The settings and keybindings should be available via the Package Settings menu, not just via the command palette (although the entries there are definitely appreciated).
• Your code assumes the package resides in a CodempClient directory, but since the package is named Codemp here, that will also be its directory name, as well as its name in package control. Note that when manually installed, or indeed when developing the package, that should also be the directory name (ie. a simple git clone in to Packages will break references to the settings file etc.).

[ghyatzo]

Ah good catch regarding the CodempClient name. It was the name when I created the package initially but forgot to update it.

Thanks for the review, much appreciated. I'll fix the naming issue And add entries in the package settings menu entry.

One small question, the package depends on a library codemp (lowercase, already registered).
I assumed there won't be conflict issues given they are in two separate registries, can you confirm this please?

[braver]

I assumed there won't be conflict issues given they are in two separate registries, can you confirm this please?

That's a good point actually, I didn't think about that. They're in different registries, but all packages, dependency or not, end up in the same namespace. I'm not sure we can rely on case-sensitivity to help here, perhaps for clarity's sake we shouldn't. "Codemp Client" is not a bad name for this package either?

[ghyatzo]

Ok thanks! I'll think a bit about it. I'll also consider to change the library name instead.

[ghyatzo]

@braver sorry for the delay.
I've decided to keep Codemp and I'll change the library entry instead.
So you can go ahead for now!
I'll make a PR to change the name of the library.