-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Claudette #9031
Add Claudette #9031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Claudette
Results help
Packages added:
- Claudette
Processing package "Claudette"
- ERROR: The binding ['super+k', 'super+c'] unconditionally overrides a default binding
- File: Default.sublime-keymap
- WARNING: The binding ['up'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
- WARNING: The binding ['down'] is also defined in default bindings but is masked with a 'context'
- File: Default.sublime-keymap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Claudette
Results help
Packages added:
- Claudette
Processing package "Claudette"
- WARNING: Binding defines supplementary keys {'platform'}
- File: Default.sublime-keymap
- Binding: {"command": "claudette_ask_question", "keys": ["super+c", "super+l"], "platform": "osx"}
- WARNING: Binding defines supplementary keys {'platform'}
- File: Default.sublime-keymap
- Binding: {"command": "claudette_ask_question", "keys": ["ctrl+c", "ctrl+l"], "platform": "windows"}
- WARNING: Binding defines supplementary keys {'platform'}
- File: Default.sublime-keymap
- Binding: {"command": "claudette_ask_question", "keys": ["ctrl+c", "ctrl+l"], "platform": "linux"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Claudette
Packages added:
- Claudette
Processing package "Claudette"
- All checks passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Claudette
Packages added:
- Claudette
Processing package "Claudette"
- All checks passed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Claudette
Packages added:
- Claudette
Processing package "Claudette"
- All checks passed
Thanks for your review @braver, much appreciated.
The way the settings menu is currently implemented is that it will open the settings in a split view, which I think is what the package control channel asks to do, and is also how I see other packages implement it. Adding separate links for the default and user settings does not seem helpful but I might be misunderstanding your request?
I've added a Claudette: Settings command now.
I've added a Privacy & Legal section to the readme.
Thanks for the suggestion, added!
Appreciate your feedback and concerns, let's keep it as-is. |
Sorry, my fault. The edit_settings command takes both a base_file and a user_file argument, and I was unsure if the user_file (or a default value) were required... but it's not, so just ignore me 😄
Sure! With the added labels and a good repo description you should be good. |
Gotcha, yup after looking into this I saw that other packages were passing a default value, added that as well for good measure. Thanks again @braver for your time! |
My package is https://github.com/barryceelen/Claudette
There are no packages specific to interacting with the Claude API like it in Package Control.