Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Claudette #9031

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Add Claudette #9031

merged 2 commits into from
Jan 26, 2025

Conversation

barryceelen
Copy link
Contributor

@barryceelen barryceelen commented Jan 5, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is https://github.com/barryceelen/Claudette

There are no packages specific to interacting with the Claude API like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Claudette
Results help

Packages added:
  - Claudette

Processing package "Claudette"
  - ERROR: The binding ['super+k', 'super+c'] unconditionally overrides a default binding
    - File: Default.sublime-keymap
  - WARNING: The binding ['up'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['down'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Claudette
Results help

Packages added:
  - Claudette

Processing package "Claudette"
  - WARNING: Binding defines supplementary keys {'platform'}
    - File: Default.sublime-keymap
    - Binding: {"command": "claudette_ask_question", "keys": ["super+c", "super+l"], "platform": "osx"}
  - WARNING: Binding defines supplementary keys {'platform'}
    - File: Default.sublime-keymap
    - Binding: {"command": "claudette_ask_question", "keys": ["ctrl+c", "ctrl+l"], "platform": "windows"}
  - WARNING: Binding defines supplementary keys {'platform'}
    - File: Default.sublime-keymap
    - Binding: {"command": "claudette_ask_question", "keys": ["ctrl+c", "ctrl+l"], "platform": "linux"}

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Claudette

Packages added:
  - Claudette

Processing package "Claudette"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Claudette

Packages added:
  - Claudette

Processing package "Claudette"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Jan 26, 2025

  • Your menu entry for settings don't specify a "user" file. It's also recommended to expose the settings via the command palette.
  • As always for packages like this, the readme must be clear and unambiguous as to how and when code might leave the user's machine (if that happens at all, not sure in this particular case): that might not always be obvious or intuitive, and might be a problem in certain scenarios.
  • We don't have recommended labels for these kinds of packages, but you might want to add ai.
  • The package name is entirely up to you, but you could consider something more explicitly linked to Claude. "Claude Client" for instance would be less clever, but more immediately understood, and might make more people find your package more easily. ... maybe it says more about me than about your package, but I didn't immediately get it 😅

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Claudette

Packages added:
  - Claudette

Processing package "Claudette"
  - All checks passed

@barryceelen
Copy link
Contributor Author

Thanks for your review @braver, much appreciated.

Your menu entry for settings don't specify a "user" file

The way the settings menu is currently implemented is that it will open the settings in a split view, which I think is what the package control channel asks to do, and is also how I see other packages implement it. Adding separate links for the default and user settings does not seem helpful but I might be misunderstanding your request?

It's also recommended to expose the settings via the command palette

I've added a Claudette: Settings command now.

As always for packages like this, the readme must be clear and unambiguous as to how and when code might leave the user's machine

I've added a Privacy & Legal section to the readme.

We don't have recommended labels for these kinds of packages, but you might want to add ai

Thanks for the suggestion, added!

The package name is entirely up to you

Appreciate your feedback and concerns, let's keep it as-is.

@braver
Copy link
Collaborator

braver commented Jan 26, 2025

but I might be misunderstanding your request

Sorry, my fault. The edit_settings command takes both a base_file and a user_file argument, and I was unsure if the user_file (or a default value) were required... but it's not, so just ignore me 😄

Appreciate your feedback and concerns, let's keep it as-is.

Sure! With the added labels and a good repo description you should be good.

@braver braver merged commit 1988dda into wbond:master Jan 26, 2025
2 checks passed
@barryceelen
Copy link
Contributor Author

The edit_settings command takes both a base_file and a user_file argument

Gotcha, yup after looking into this I saw that other packages were passing a default value, added that as well for good measure.

Thanks again @braver for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants