Local typehead search

[lokal-profil]

Bug: T317109

[lokal-profil]

This is a tentative patch for T317109 and the issue mentioned at the end of wbstack/cradle#2

Not used to vue and couldn't test this locally but it matches the pattern applied to public_html/resources/vue/wd-link.html

[lokal-profil]

Might also be that wd_api_base + 'api.php?callback=?' could be replaced by wd.api per how this gets overridden by https://github.com/wbstack/cradle/blob/514f299e78db048d99afc3662afed7eda4a28631/public_html/vue.js#L78 and

magnustools/public_html/resources/js/wikidata.js

Lines 391 to 393 in 785d496

	this.set_custom_api = function ( api , callback ) {
	let self = this ;
	api += "?callback=?"

[tarrow]

Thanks for this patch; it was indeed rather tricky to test locally. I am happy to report that it does appear to fix the search aspect of the problem (e.g. you only see results from your wikibase)

However, I noticed that after testing it locally that the items it created after using this adjustment were malformed. Specifically they target an item with the id of the the page title rather than the item id. See this screenshot below:

The fact that this is possible seems to me to also be a wikibase bug but this request should also not happen from cradle/widar.

I was hoping to just merge this PR as "not perfect but better than the status quo" but I fear that doing so will result in people on wikibase.cloud creating a load of items that are rather malformed. I'm going to have to investigate this a little further. Thanks for your patience :)

[lokal-profil]

@tarrow
Since local testing of this is still an issue for me. Are these malformed values ones that didn't occur before the patch? I.e. If you were to manually enter Q2 and choose the local hit.

[lokal-profil]

Actually I realised that there is probably a namespace issue as well in that public_html/resources/vue/typeahead-search.htmlon L124 (in this patch L121 otherwise) assumes Properties on namespace 120 and (presumably) Items on namespace 0. Whereas on a wikibase-cloud instance Items are on 120 and Properties on 122.

[lokal-profil]

@tarrow Since local testing of this is still an issue for me. Are these malformed values ones that didn't occur before the patch? I.e. If you were to manually enter Q2 and choose the local hit.

I believe the issue might lie with the use of v.title on L148 (L131) rather than v.id. These are identical on Wikidata but not so on a Wikibase.cloud instance.

Also if you have tips about a local testing setup I'd be happy to try that.

[lokal-profil]

Actually I realised that there is probably a namespace issue as well in that public_html/resources/vue/typeahead-search.htmlon L124 (in this patch L121 otherwise) assumes Properties on namespace 120 and (presumably) Items on namespace 0. Whereas on a wikibase-cloud instance Items are on 120 and Properties on 122.

Separated this issue out into a patch at #7