fix: propagate status code from platform api when routing wiki requests

[m90]

Ticket: https://phabricator.wikimedia.org/T343744

I tested this locally by:

• requesting a wiki that does not exist, receiving a 404
• hard coding an error for a certain wiki in api, seeing a 500

diff --git a/app/Http/Controllers/Backend/WikiController.php b/app/Http/Controllers/Backend/WikiController.php
index 2343cd3..b8469ff 100644
--- a/app/Http/Controllers/Backend/WikiController.php
+++ b/app/Http/Controllers/Backend/WikiController.php
@@ -13,6 +13,9 @@ class WikiController extends Controller
     public function getWikiForDomain(Request $request): \Illuminate\Http\JsonResponse
     {
         $domain = $request->input('domain');
+        if ($domain === 'thirdwiki.wbaas.localhost') {
+            throw \Exception("THE DINOSAURS ESCAPED");
+        }
 
         // XXX: this same logic is in quickstatements.php and platform api WikiController backend
         try {

[m90]

The entire GlobalSet class is a bit twisted and this PR does not necessarily improve it as it somehow tries to follow the current call chain. We might also think about rewriting this thing in its entirety.

[tarrow]

I think this makes sense and probably propagating the precise nature of the failure with an Exception.

In any case this probably makes sense and is then super clear that this is really a side effect only function.

Naturally trying to write this in a clean way is pretty hard since the desired behaviour is charging around a setting a load of globals

[tarrow]

So the linting here looks "funny" because MediaWiki uses a very non-php standard code style. No objection to this being changed here since we don't lint this anyway but perhaps in future we should add linting to match the MediaWiki style to this weird codebase in dist-persist

[m90]

I mean if we want a code style, then it should be applied everywhere. I just tried to make it consistent per function. Which is probably futile ...

[tarrow]

If you want to add more "formal" testing you can add stuff to https://github.com/wbstack/mediawiki/blob/main/.github/workflows/mediawiki.verify.yml and to the fake api at https://github.com/wbstack/mediawiki/tree/main/docker-compose/fake-api

[m90]

If you want to add more "formal" testing you can add stuff to

Ah I didn't know about these, that's very helpful.

[m90]

@tarrow I refactored this so that it now caches any kind of response and also added "tests". Mind taking another look?

[tarrow]

I think we still need to check what happens here; in the event this parsing fails and the static here returns a null we should build a WBStackLookupFailure; not quite sure how graceful or not failure would be in this case (since the logic in WBStackInfo is also very unpolished)

I tried this locally in a not super smart way as you can see at #411

[m90]

Yeah, good catch, we shall add this still. Will do so right away.

[m90]

@tarrow Added this in 75c7bd9

[tarrow]

Most realistic!