Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unittests #41

Merged
merged 13 commits into from
Oct 24, 2024
Merged

Feature/unittests #41

merged 13 commits into from
Oct 24, 2024

Conversation

BerSomBen
Copy link
Collaborator

Hi @tobias-richter,

I added unittests for all models that base on json responses and verify the serialization with sample-json data.

while writing the tests, I noticed that some of the models where not in the correct file, those where moved.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your code using rustfmt: cargo fmt

@github-actions github-actions bot dismissed their stale review October 18, 2024 18:36

Removing outdated review.

@BerSomBen
Copy link
Collaborator Author

Hi @tobias-richter,
I made some adaptions to fit our naming and language conventions.

I think, this MR should first.

Copy link
Contributor

@tobias-richter tobias-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks

@@ -0,0 +1,5 @@
{
"access_token": "das.ist.ein.token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

german language used

@BerSomBen BerSomBen merged commit 2f0ce53 into main Oct 24, 2024
6 checks passed
@BerSomBen BerSomBen deleted the feature/unittests branch October 24, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants