-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/unittests #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format your code using rustfmt: cargo fmt
…hen empty service string is in the backend data
Hi @tobias-richter, I think, this MR should first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nitpicks
test/test_auth_bearer_response.json
Outdated
@@ -0,0 +1,5 @@ | |||
{ | |||
"access_token": "das.ist.ein.token", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
german language used
Add unittests for environment variables
Hi @tobias-richter,
I added unittests for all models that base on json responses and verify the serialization with sample-json data.
while writing the tests, I noticed that some of the models where not in the correct file, those where moved.