Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve #166

Merged
merged 1 commit into from
Feb 21, 2025
Merged

docs: improve #166

merged 1 commit into from
Feb 21, 2025

Conversation

wcxve
Copy link
Owner

@wcxve wcxve commented Feb 21, 2025

Summary by Sourcery

Documentation:

  • Replaced the term 'pivot energy' with 'reference energy' in the documentation of several spectral models for clarity and consistency.

Copy link

sourcery-ai bot commented Feb 21, 2025

Reviewer's Guide by Sourcery

This pull request changes the term 'pivot energy' to 'reference energy' in the documentation of several models within the elisa.models.add module. This change aims to improve the clarity and accuracy of the documentation by using more precise terminology.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced 'pivot energy' with 'reference energy' in the documentation of multiple models.
  • Replaced 'pivot energy' with 'reference energy' in the Band model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the BandEp model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the CutoffPL model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the Compt model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the OTTB model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the PowerLaw model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the PLPhFlux model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the PLEnFlux model documentation.
  • Replaced 'pivot energy' with 'reference energy' in the SmoothlyBrokenPL model documentation.
src/elisa/models/add.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wcxve - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This looks like a find-and-replace, so double-check that all instances of 'pivot energy' should be changed to 'reference energy'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wcxve wcxve merged commit 555a732 into main Feb 21, 2025
9 checks passed
@wcxve wcxve deleted the docs branch February 21, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant