Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try out typed tests #87

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

try out typed tests #87

wants to merge 2 commits into from

Conversation

germasch
Copy link
Contributor

This is mostly to see what the CI says, since I think this isn't ready for primetime.

I think fundamentally, typed tests are a good way to avoid duplication. My original goal was to specialize tests, for float, double, gt::complex<float>, etc., but that hit some early obstacles (which need more looking at, and probably should be fixed.)

So I went ahead with the other thing I was thinking to do, ie., generating tests for gt::space::host and gt::space::device. And while this works with CUDA, I think the way it is now, it assumes that device arrays can be initialized and accessed on the host, which we probably don't want to depend on in general (ie., without thrust).

But so it also is actually a good starting point for a discussion on how to have an easy interface for writing gtensor code that can be compiled into gpu or cpu code transparently.

@bd4
Copy link
Contributor

bd4 commented Apr 21, 2021

This looks reasonable. I did some templated tests e.g. in test_fft, but without using the googletest support - I just called a templated test method from different TEST annotated calls. This scales better to more than two tests, even if the syntax isn't the most elegant thing.

@germasch germasch marked this pull request as ready for review April 21, 2021 16:11
@germasch
Copy link
Contributor Author

I don't mean to say it's ready for review, I'm just wondering whether the Draft status is why the CI didn't run. Or maybe that's a consequence of the rename of the main branch....

@germasch germasch marked this pull request as draft April 21, 2021 16:15
@bd4
Copy link
Contributor

bd4 commented Apr 21, 2021

I guess CI config is one thing the github feature does not do yet...

germasch added 2 commits May 20, 2021 07:55
Actually, my goal was to include tests for complex numbers, but that doesn't
appear to be as straightforward as I was hoping...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants