Feature/dynamic rag support #1377
Conversation
…enerate` methods
…ient into feature/dynamic-rag-support
|
Great to see you again! Thanks for the contribution. |
…g on LLM performance
…ient into feature/dynamic-rag-support
| temperature=temperature, | ||
| top_p=top_p, | ||
| is_azure=is_azure or False, | ||
| ) |
There was a problem hiding this comment.
should we have a "custom" method? 🤔 Mainly thinking about the generative-dummy module
There was a problem hiding this comment.
The problem with a custom provider is the strong typing of the protobuf message. I think it would work if we had some parsing on the server-side to handle a JSON object but since we don't have that it wouldn't be useful at this stage. I think adding a dummy method would make sense
| temperature=temperature, | ||
| top_p=top_p, | ||
| is_azure=is_azure or False, | ||
| ) |
There was a problem hiding this comment.
How would you implement image/video generation for an existing provider? XXX_image(...)?
…ient into feature/dynamic-rag-support
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 88.25% 88.19% -0.07%
==========================================
Files 186 187 +1
Lines 15875 16098 +223
==========================================
+ Hits 14011 14198 +187
- Misses 1864 1900 +36 ☔ View full report in Codecov by Sentry. |
No description provided.