Add ability to freeze timeline clock for testing #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Players may have non-zero start time, and/or playback rates other than one. As noted in Issue web-animations#628, calling document.timeline._pauseAnimationsForTesting with the current timeline time will change such players' currentTime, and will change the animated elements' computed style. We implement a new testing method _freezeClockForTesting that avoids changing any of the players, it simply freezes the timeline's currentTime to the supplied time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Players may have non-zero start time, and/or playback rates other than
one. As noted in https://github.com/web-animations/web-animations-js/issues/628, calling document.timeline._pauseAnimationsForTesting
with the current timeline time will change such players' currentTime, and
will change the animated elements' computed style.
We implement a new testing method _freezeClockForTesting that avoids
changing any of the players, it simply freezes the timeline's
currentTime to the supplied time.