Preparing 5.0.0 #520
Closed
Preparing 5.0.0 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
commented
Nov 16, 2023
Closed
Spomky
commented
Nov 16, 2023
| @@ -52,8 +52,5 @@ | |||
| "web-token/jwt-signature-algorithm-ecdsa": "Recommended for the AndroidSafetyNet Attestation Statement support", | |||
| "web-token/jwt-signature-algorithm-eddsa": "Recommended for the AndroidSafetyNet Attestation Statement support", | |||
| "symfony/event-dispatcher": "Recommended to use dispatched events" | |||
| }, | |||
There was a problem hiding this comment.
To be addressed in 4.8.x
src/webauthn/src/Denormalizer/AttestationObjectDenormalizer.php
Outdated
Show resolved
Hide resolved
Spomky
added
help wanted
Spomky
force-pushed
the
remove-deprecations
branch
from
734c7b7 to
c4d42c2
Compare
Spomky
commented
Nov 19, 2023
| @@ -30,7 +30,7 @@ public function findUserEntity(Request $request): PublicKeyCredentialUserEntity | |||
| $format = method_exists( | |||
| $request, | |||
| 'getContentTypeFormat' | |||
| ) ? $request->getContentTypeFormat() : $request->getContentType(); | |||
| ) ? $request->getContentTypeFormat() : $request->getContentTypeFormat(); | |||
| @@ -91,26 +84,15 @@ public function setEventDispatcher(EventDispatcherInterface $eventDispatcher): v | |||
| $this->dispatcher = $eventDispatcher; | |||
| } | |||
|
|
|||
| public static function create(): self | |||
| public static function create(ClockInterface $clock): self | |||
There was a problem hiding this comment.
To be addressed in 4.8.x
|
|
||
| final class TrustPathDenormalizer implements DenormalizerInterface | ||
| { | ||
| public function denormalize(mixed $data, string $type, string $format = null, array $context = []) | ||
| public function denormalize(mixed $data, string $type, string $format = null, array $context = []): mixed |
There was a problem hiding this comment.
To be addressed in 4.8.x
tests/library/Functional/AttestationStatementWithTokenBindingTest.php
Outdated
Show resolved
Hide resolved
Spomky
force-pushed
the
remove-deprecations
branch
from
62f6a48 to
8d70382
Compare
Spomky
force-pushed
the
remove-deprecations
branch
from
8d70382 to
7cb2ad9
Compare
The "minimum-stability" setting in the composer.json file was removed since we had already achieved a stable production phase. It was originally set to "beta", which is not necessary anymore.
Simplified the structuring of authenticatorSelection data in RegistrationAreaTest and made handling of JSON encoding errors more explicit in BiometricAccuracyDescriptorObjectTest and AttestedCredentialDataTest. This aims to make the tests more readable and robust against potential encoding issues.
Reformatted all CASE statements in TPMAttestationStatementSupport.php and RequestBodyUserEntityGuesser.php to have a space before the colon for improved readability, following the standard coding style guide.
|
SonarCloud Quality Gate failed.
|
|
Closing in favor of #557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications: