Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: banner plugin switch condition #721

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

easy1090
Copy link
Contributor

@easy1090 easy1090 commented Jan 24, 2025

Summary

Change the InternalBundleTagPlugin to turn on the logic, when "supports. Banner' is true, or the BannerPlugin plug-in is used by default and supports. When banner' is not false, the InternalBundleTagPlugin analysis ability will be turned on.
————————————————————————————————————————————————————————————
更改 InternalBundleTagPlugin 开启逻辑,当 supports.banner 为 true,或默认使用了 BannerPlugin 插件且 supports.banner 不为 false 时,会开启 InternalBundleTagPlugin 分析能力。

Related Links

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit 6ff8df5
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/679344a341d2ea0008bda9ab
😎 Deploy Preview https://deploy-preview-721--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit 5609239
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/679357a499e2d600082f0a0d
😎 Deploy Preview https://deploy-preview-721--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@easy1090 easy1090 force-pushed the fix/banner-plugin-switch branch 3 times, most recently from 0deef18 to 4a5100f Compare January 24, 2025 08:38
@easy1090 easy1090 force-pushed the fix/banner-plugin-switch branch from 75b41d2 to de5943f Compare January 24, 2025 08:42
@easy1090 easy1090 requested review from 9aoy and chenjiahan January 24, 2025 08:47
9aoy
9aoy previously approved these changes Jan 24, 2025
@easy1090 easy1090 requested a review from chenjiahan January 24, 2025 09:08
@easy1090 easy1090 enabled auto-merge (squash) January 24, 2025 09:10
@easy1090 easy1090 requested a review from SoonIter January 24, 2025 09:13
@easy1090 easy1090 merged commit 343c727 into main Jan 24, 2025
7 checks passed
@easy1090 easy1090 deleted the fix/banner-plugin-switch branch January 24, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants