-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: banner plugin switch condition #721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
easy1090
force-pushed
the
fix/banner-plugin-switch
branch
3 times, most recently
from
January 24, 2025 08:38
0deef18
to
4a5100f
Compare
easy1090
force-pushed
the
fix/banner-plugin-switch
branch
from
January 24, 2025 08:42
75b41d2
to
de5943f
Compare
9aoy
previously approved these changes
Jan 24, 2025
chenjiahan
reviewed
Jan 24, 2025
SoonIter
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the InternalBundleTagPlugin to turn on the logic, when "supports. Banner' is true, or the BannerPlugin plug-in is used by default and supports. When banner' is not false, the InternalBundleTagPlugin analysis ability will be turned on.
————————————————————————————————————————————————————————————
更改 InternalBundleTagPlugin 开启逻辑,当
supports.banner
为 true,或默认使用了 BannerPlugin 插件且supports.banner
不为 false 时,会开启 InternalBundleTagPlugin 分析能力。Related Links