Add five new web platform feature groups #78
Conversation
There was a problem hiding this comment.
Love where this is going. I left a few comments which, I hope, will be useful.
In terms of next steps, I'd be curious to see what a "web components" group would look like (since you've already done custom elements and shadow dom, it seems like a good next step).
| @@ -0,0 +1,30 @@ | |||
| spec: https://drafts.csswg.org/css-grid-3/ | |||
| caniuse: css-grid | |||
| compat_features: | |||
There was a problem hiding this comment.
I think we're missing the place-content, place-items, place-self, align-content, and justify-content properties.
You've got self and items for both justify and align directions, but you also need content (which applies to a grid container element and applies to the alignment "subjects" in the grid, aka the row and column tracks). And you need place too, which is the short-hand for align and justify.
There was a problem hiding this comment.
I've added the missing properties (fea20dc).
I noticed an interesting omission in the process: there also exist legacy aliases (grid-column-gap and grid-row-gap) to the current column-gap and row-gap. Makes me wonder whether we should acknowledge them somehow, though it would require some changes to BCD (the data for those aliases is present, but incorrectly structured).
cc: @foolip
There was a problem hiding this comment.
If the data is structured correctly the question becomes: should we treat aliases or prefixes as full support, and making the feature eligible for baseline, or should we treat it like an important note that should be called out when support is summarized? I'd lean towards the latter.
There was a problem hiding this comment.
That's a good question! I've opened #86 to preserve it (and to raise some closely related questions).
| spec: https://drafts.csswg.org/css-grid-3/ | ||
| caniuse: css-grid | ||
| compat_features: | ||
| - css.properties.align-items |
There was a problem hiding this comment.
Can we add the minmax function too? I don't know where it is in BCD right now though. Maybe it's already included in the repeat function which you've already added.
Also, the auto-fit and auto-fill values should be in there somewhere (they probably already are in the repeat function in fact).
There was a problem hiding this comment.
I've added the missing minmax value (fea20dc).
auto-fit and auto-fill don't exist as separate features in BCD. BCD doesn't always contain CSS type/value subfeatures, especially when they're likely to be implemented simultaneously with the parent type or property. I don't think that's a problem here, though it's fixable if we have reason to believe that the support differs.
- align-content - justify-content - place-items - place-self - minmax
|
Thanks for the reviews, y'all. I'm going to merge this and dig into some of the consequences. 👍 |
Hi @captainbrosset and @anthumchris! Thanks for taking the time to review some of this. Hopefully this won't take a ton of time, but feel free to limit the time you spend on this to a level that's comfortable for your schedule and interest.
This PR adds five new features to the feature set. I'd like your first impressions, as someone who knows about web technologies in general (though perhaps not specifically these features), but does not know anything about the specifics of feature-set.
Please note that this is an experiment. So far, Philip and I are the only ones to have reviewed new features. We don't yet know what other reviewers might need to make good use of reviewing time. Finding the stumbling blocks is as important as coming up with good features and definitions for them.
Third, I've written some optional prompts in the next section to help you understand what I'm looking for, but feel free to go off script. 🙂
Feedback hints
I'm looking for feedback both substantive and procedural. Here are some prompts which may guide you:
compat_features. I don't expect you're a browser-compat-data expert, but does the list of related features look plausible?