[WPT] Distinguish base URLs in string-compilation-of-promise-result.html #30241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 30, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3130646
branch
3 times, most recently
from
2bd9559
to
4befa2a
Compare
The tests fail on Safari/Firefox/Chromium, and thus this change exposes that the browsers set no active scripts for `Promise.resolve(...).then(eval)`. Bug: 1245063, whatwg/webidl#902 Change-Id: Ic7debcd66e3f90c2fcb973d1e4100daabf2895dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3130646 Commit-Queue: Hiroshige Hayashizaki <[email protected]> Reviewed-by: Domenic Denicola <[email protected]> Cr-Commit-Position: refs/heads/main@{#918862}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3130646
branch
from
4befa2a
to
5b3ca0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests fail on Safari/Firefox/Chromium, and thus this change
exposes that the browsers set no active scripts for
Promise.resolve(...).then(eval).Bug: 1245063, whatwg/webidl#902
Change-Id: Ic7debcd66e3f90c2fcb973d1e4100daabf2895dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3130646
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/main@{#918862}