Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLEDGE]: Add trustedBiddingSignalsSlotSizeMode to InterestGroups. #43425

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 29, 2023

This CL adds the trustedBiddingSignalsSlotSizeMode to the Protected
Audience API's InterestGroups, and saves them to the database. The
new field currently doesn't have any actual effect.

See WICG/turtledove#928 for API description.

Bug: 1506238
Change-Id: I7133436c813076274822db522ece1a668dba51e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063314
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1231648}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [PLACEHOLDER]: Ad slot size stuff [FLEDGE]: Add trustedBiddingSignalsSlotSizeMode to InterstGroups. Nov 29, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [FLEDGE]: Add trustedBiddingSignalsSlotSizeMode to InterstGroups. [FLEDGE]: Add trustedBiddingSignalsSlotSizeMode to InterestGroups. Nov 29, 2023
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-5063314 branch 2 times, most recently from 1838f5c to 4043c4b Compare November 30, 2023 01:19
This CL adds the trustedBiddingSignalsSlotSizeMode to the Protected
Audience API's InterestGroups, and saves them to the database. The
new field currently doesn't have any actual effect.

See WICG/turtledove#928 for API description.

Bug: 1506238
Change-Id: I7133436c813076274822db522ece1a668dba51e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063314
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1231648}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ba3a000 into master Dec 1, 2023
21 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5063314 branch December 1, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants