Make customizable select options listen to mouseup #49684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouseup is better than mousedown because it allows the user to click and drag to choose an option like appearance:auto already does. More justification here: whatwg/html#10762 (comment) Change-Id: Ifa63d497b7dcfbc3d07e19d6a7850bddf57f78fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077672 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396126}
wpt-pr-bot
approved these changes
Dec 13, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6077672
branch
from
79eb5c1 to
40d8f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouseup is better than mousedown because it allows the user to click and
drag to choose an option like appearance:auto already does. More
justification here:
whatwg/html#10762 (comment)
Change-Id: Ifa63d497b7dcfbc3d07e19d6a7850bddf57f78fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077672
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Traian Captan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1396126}