Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap-2] Add shadow DOM test for scroll-initial-target #50101

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2025

Per request[1] from HTML spec reviewers, this adds a test that scroll
containers in shadow trees also honor their scroll-initial-targets.

[1] whatwg/html#10759 (review)

Bug: 40909052
Change-Id: I5ff8029dbe043ebdcf3cc18473e014140247c0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165203
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: David Awogbemila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406768}

Per request[1] from HTML spec reviewers, this adds a test that scroll
containers in shadow trees also honor their scroll-initial-targets.

[1] whatwg/html#10759 (review)

Bug: 40909052
Change-Id: I5ff8029dbe043ebdcf3cc18473e014140247c0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165203
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: David Awogbemila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406768}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d3a1594 into master Jan 15, 2025
16 of 18 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6165203 branch January 15, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants