feat: configure the plugin, add first method addEthereumChain #2
Conversation
krzysu
force-pushed
the
feat-init-setup
branch
from
2283ec5 to
4abff9d
Compare
krzysu
changed the title
|
https://github.com/web3/web3-wallet-rpc-utils/blob/main/package.json#L39 |
|
Looks good! |
| - wallet_addEthereumChain (EIP-3085) | ||
| - wallet_updateEthereumChain (EIP-2015) | ||
| - wallet_switchEthereumChain (EIP-3326) | ||
| - wallet_getOwnedAssets (EIP-2256) | ||
| - wallet_watchAsset (EIP-747) | ||
| - wallet_requestPermissions (EIP-2255) | ||
| - wallet_getPermissions (EIP-2255) |
There was a problem hiding this comment.
It seems like this PR only adds support for one of these methods. It may be a good idea to note that the other methods are not yet supported.
There was a problem hiding this comment.
yes, this is WIP, I'll add them all before the plugin is ready for release
| super(); | ||
| } | ||
|
|
||
| public async addEthereumChain(param: AddEthereumChainRequest): Promise<null> { |
There was a problem hiding this comment.
Documentation comments here would be nice
There was a problem hiding this comment.
This is coming in the next PR
| import { Web3PluginBase, utils } from "web3"; | ||
| import { AddEthereumChainRequest } from "./types"; | ||
|
|
||
| type WalletRpcApi = { |
There was a problem hiding this comment.
Why isn't this defined in types.ts?
There was a problem hiding this comment.
all types from types.ts are exported from the plugin package to use outside of it, this one is for internal use only.
| "extends": "./tsconfig.json", | ||
| "include": ["src"] | ||
| } |
There was a problem hiding this comment.
Why has the exclude property been removed?
There was a problem hiding this comment.
I understand that include is enough if we want to build only src folder, using both doesn't change anything and I find it even more confusing, as exclude didn't mention all other folders in the repo anyway.
|
I just noticed that there is no LICENSE file in this repository. |
|
Noted:
|
krzysu
force-pushed
the
feat-init-setup
branch
4 times, most recently
from
0bd6f66 to
e62782d
Compare
Signed-off-by: Kris Urbas <[email protected]>
krzysu
force-pushed
the
feat-init-setup
branch
from
e62782d to
32f2226
Compare
No description provided.