feat: add example react app to test wallet plugin #3
Conversation
krzysu
force-pushed
the
feat-example-app
branch
2 times, most recently
from
0e0fa84 to
338a5d4
Compare
|
I actually transitioned to a monorepo in a follow-up PR #5 |
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 web3js-react-dapp-demo | |||
There was a problem hiding this comment.
Is it important to change this?
There was a problem hiding this comment.
I removed example app license as I don't think it is relevant here, I kept plugin license in the repo's root
| # Web3.js + React Demonstration dApp | ||
|
|
||
| This project is a demonstration dApp built with [Web3.js](https://web3js.org/) | ||
| and [React](https://react.dev/). | ||
|
|
||
| - [Web3.js Docs](https://docs.web3js.org/) | ||
| - [React Docs](https://react.dev/learn) | ||
|
|
||
| This project was bootstrapped with | ||
| [Create React App](https://github.com/facebook/create-react-app). | ||
|
|
||
| ## Getting Started | ||
|
|
||
| Install the project dependencies with a dependency manager like npm or Yarn. Use | ||
| `npm start` to start a local development server and navigate to | ||
| http://localhost:3000 to view the dApp. |
There was a problem hiding this comment.
Would be nice to update this.
There was a problem hiding this comment.
what would you like to update here? the example app's purpose is to allow for manual tests of the wallet rpc plugin with different extension wallets
| "name": "web3js-react-dapp-demo", | ||
| "version": "0.1.0", | ||
| "description": "Demonstration Web3.js + React dApp", |
There was a problem hiding this comment.
I would update the name and description here
| <meta name="theme-color" content="#000000" /> | ||
| <meta | ||
| name="description" | ||
| content="Web3.js + React demonstration dApp" |
| work correctly both with client-side routing and a non-root public URL. | ||
| Learn how to configure a non-root public URL by running `npm run build`. | ||
| --> | ||
| <title>Web3.js + React Demonstration dApp</title> |
| "short_name": "Web3.js + React dApp", | ||
| "name": "Web3.js + React Demonstration dApp", |
|
|
||
| return ( | ||
| <main> | ||
| <h1>Web3.js + React Minimal dApp Template</h1> |
There was a problem hiding this comment.
I need to change this in the template!
|
Why doesn't the example dApp actually use the plugin? |
krzysu
force-pushed
the
feat-init-setup
branch
5 times, most recently
from
e62782d to
32f2226
Compare
Signed-off-by: Kris Urbas <[email protected]>
krzysu
force-pushed
the
feat-example-app
branch
from
338a5d4 to
244812b
Compare
|
@danforbes thanks for the review, I will apply all your comments in a follow up PR #5 as I'm afraid the changes might get lost as I restructured a lot of files later. The usage of a plugin is coming in later PRs as well. |
based on Dan's https://github.com/web3/create-web3js-dapp