Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): external-provider #7119

Open
wants to merge 9 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

danforbes
Copy link
Contributor

Add documentation for external providers.

Closes #7115

Copy link

github-actions bot commented Jun 21, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 637.83 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 618.53 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c24010d Previous: 4f8e8cc Ratio
processingTx 21813 ops/sec (±7.95%) 21886 ops/sec (±6.09%) 1.00
processingContractDeploy 39868 ops/sec (±7.20%) 38750 ops/sec (±9.06%) 0.97
processingContractMethodSend 15840 ops/sec (±7.05%) 15198 ops/sec (±8.03%) 0.96
processingContractMethodCall 27633 ops/sec (±6.69%) 26542 ops/sec (±7.32%) 0.96
abiEncode 42330 ops/sec (±7.69%) 40956 ops/sec (±7.46%) 0.97
abiDecode 29030 ops/sec (±8.08%) 29461 ops/sec (±6.44%) 1.01
sign 1476 ops/sec (±3.30%) 1499 ops/sec (±3.97%) 1.02
verify 360 ops/sec (±0.45%) 355 ops/sec (±0.76%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (6b80cf0) to head (c24010d).
Report is 49 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7119      +/-   ##
==========================================
+ Coverage   94.45%   94.47%   +0.01%     
==========================================
  Files         215      215              
  Lines        8391     8411      +20     
  Branches     2313     2321       +8     
==========================================
+ Hits         7926     7946      +20     
  Misses        465      465              
Flag Coverage Δ
UnitTests 94.47% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some next PR when RPC providers package is added in libdocs, I think its link and one line intro also needs to be in https://docs.web3js.org/#packages--plugins section.

@jdevcs
Copy link
Contributor

jdevcs commented Jun 25, 2024

this PR looks good, Thanks @danforbes

@Redoudou
Copy link
Contributor

@danforbes @jdevcs you can use the code WEB3JS and user will get 20% off for 2 months when they switch to a paid RPC provider with Quick Nodes.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 21, 2024
@danforbes
Copy link
Contributor Author

Still active

@github-actions github-actions bot removed the Stale Has not received enough activity label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation for Quicknode provider feature
5 participants