Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error in JSDoc example for sha3Raw #7457

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

mdqst
Copy link

@mdqst mdqst commented Feb 6, 2025

Description

I noticed a error in the JSDoc example for sha3Raw. The example had conosle.log instead of console.log, which could cause confusion or errors if copied as-is. Fixed it to ensure the example runs correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@mdqst
Copy link
Author

mdqst commented Feb 7, 2025

AlexeyKrasnoperov, Лёха, проверяй.

Copy link

@Setland34 Setland34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR/Approved #7457

@mdqst mdqst requested a review from Setland34 February 9, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants