Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember #2438

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add Ember #2438

wants to merge 15 commits into from

Conversation

NullVoxPopuli
Copy link

@NullVoxPopuli NullVoxPopuli commented Sep 28, 2024

Resolves #237

  • meta
    • no open issues regarding web-component compatibility
    • write summary
    • define expected results
  • Components' Implementation
  • Basic Tests Pass
  • Advanced Tests Pass
  • [ ] Integrate into reporting / infra tests are manually ran?

Of note, ember currently uses Vite, not webpack

old notes , so we have to make some tweaks to shoehorn a vite build into this repo's way of using webpack -- shouldn't be too bad tho.

Copy link

google-cla bot commented Sep 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Author

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review -- need to make some changes

@NullVoxPopuli NullVoxPopuli changed the title WIP: Add Ember Add Ember Mar 6, 2025
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 6, 2025 15:38
@NullVoxPopuli
Copy link
Author

ready for review <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ember.js
1 participant