fix: locator selection and outputChannel selector

[jan872]

The locator selection by vscode version did not work, because the vscode version was overwritten by the underlying chrome version and "122" was larger than all vscode versions. The vscode version is now preserved and use for locator selection.

As of vscode 1.87.0 the bottombar's outputChanel selector does not have an attribute title anymore. The locator for 1.87.0 was thus added.

[christian-bromann]

version is not a valid capability. What is the idea behind this change?

[jan872]

From line 89 I assumed that version was a valid capability, as it was used there.

The idea was to store the actual vscode version before cap.browserVersion gets overwritten here: https://github.com/webdriverio-community/wdio-vscode-service/blob/main/src/launcher.ts#L174
such that it is available here for selection of the right locators:
https://github.com/webdriverio-community/wdio-vscode-service/blob/main/src/service.ts#L207
(see https://github.com/webdriverio-community/wdio-vscode-service/pull/138/files#diff-84b68bce2abfcb25c3328df0286963d7dacc924940adc41923bf4f502a6bc95aR206)

Currently the capabilities.browserVersion is overwritten to the chrome version, and the locators may thus not be selected correctly.

[christian-bromann]

@jan872 actually this is correct, it is just changing the VSCODE_CAPABILITY_KEY capability object which can have arbitrary content.

[christian-bromann]

LGTM 👍

[wdio-bot]

Hey jan872 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖