Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contain side-effects from tests in C/I #99

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

sourishkrout
Copy link
Contributor

Follow up to #98.

  • Break out specs into separate files
  • Make them pass again

@sourishkrout
Copy link
Contributor Author

sourishkrout commented Jan 16, 2024

Test passed for various vscode versions on a Linux box (in codespaces). Hopefully 🤞 this will make them pass in GH actions, @christian-bromann.

@christian-bromann
Copy link
Contributor

Thanks for the patch 👌

@christian-bromann
Copy link
Contributor

@sourishkrout shouldn't we remove the tests from the basic.e2e.ts since they have been moved out into separate files?

@sourishkrout
Copy link
Contributor Author

@sourishkrout shouldn't we remove the tests from the basic.e2e.ts since they have been moved out into separate files?

I believe the whole file was removed. If not then I must have done something wrong during commit. Checking....

Also... Windows 🤦.

@sourishkrout
Copy link
Contributor Author

Looks like this is right:

image

@christian-bromann
Copy link
Contributor

Looks like this is right:

Yes, thanks for confirming. The GitHub UI tricked me here.

@sourishkrout
Copy link
Contributor Author

Just pushed a wdio config change to turn on retries for occasional flakes @christian-bromann.

@christian-bromann
Copy link
Contributor

I will rerun this a couple of times, knowing that some of these tests aren't stable.

@sourishkrout
Copy link
Contributor Author

Got one of the culprits to pass consistently locally. Let's see if we can get a clean build, please, @christian-bromann.

@sourishkrout
Copy link
Contributor Author

Chromedriver/Electron didn't even come up in the last run. Don't think that's related to the new commits. Crashed prematurely.

@sourishkrout
Copy link
Contributor Author

🤦 whackamole continues

@sourishkrout
Copy link
Contributor Author

🤞 hopefully this will fix it @christian-bromann

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@christian-bromann christian-bromann merged commit fc9e263 into webdriverio-community:main Jan 17, 2024
9 checks passed
@sourishkrout sourishkrout deleted the tests-passing branch January 17, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants