Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dump location quirks for vtcapture #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sundermann
Copy link
Contributor

Adds more dump locations available in the vtcapture API.

@sundermann sundermann requested a review from Copilot February 26, 2025 20:43
Copilot

This comment was marked as resolved.

@sundermann sundermann requested a review from Copilot February 26, 2025 20:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR expands the available dump locations in the vtcapture API by adding several new quirks and updating the README table accordingly.

  • Updated the table header formatting.
  • Modified the description for QUIRK_ALTERNATIVE_DUMP_LOCATION.
  • Added four new quirks with corresponding flags for alternative dump locations.

Reviewed Changes

File Description
README.md Updated table formatting and added new quirks rows

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

README.md:52

  • [nitpick] The table divider row has been modified. Please verify that the alignment and spacing render correctly in various markdown viewers.
|-------------------|-----------------------------------|---------------------------------------------------------------------------------|-------|
@TBSniller
Copy link
Collaborator

TBSniller commented Mar 3, 2025

@sundermann fyi, I recently found this information in the header files of my TVs kernel source.
drivers\rtk_kdriver\common\include\ioctrl\scaler\vt_cmd_id.h

/**
 * @brief This enumeration describes the dump location of video memory.
 */
typedef enum
{
	KADP_VT_SCALER_INPUT = 0,
	/*KADP_VT_SCALER_OUTPUT = 0,*/
	KADP_VT_SCALER_OUTPUT,
	KADP_VT_DISPLAY_OUTPUT,
	KADP_VT_OSDVIDEO_OUTPUT
} KADP_VT_DUMP_LOCATION_TYPE_T;

From this I would assume we cannot be 100% sure about the value to name mapping on all TVs.

@sundermann
Copy link
Contributor Author

I don't see the issue here. It seems to be just the same thing except for the last two locations which are missing on your device. the naming also doesn't really matter.

@TBSniller
Copy link
Collaborator

Not an issue, just a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants