Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cspell #790

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

benmccann
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

adds tinyglobby to the included dictionary, which is necessary for #788

Breaking Changes

Additional Info

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (a20dedd) to head (1558472).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   90.55%   91.48%   +0.92%     
==========================================
  Files           2        2              
  Lines         413      411       -2     
  Branches      120      119       -1     
==========================================
+ Hits          374      376       +2     
+ Misses         38       34       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snitin315
Copy link
Member

adds tinyglobby to the included dictionary,

How is this related to #788? Can't we just add tinyglobby here during migration?

@benmccann
Copy link
Contributor Author

How is this related to #788?

The word tinyglobby must be in the dictionary or the lint job for spell checking will fail. The latest version of cspell has it included

Can't we just add tinyglobby here during migration?

That would probably work too. Is it simpler than this solution though? Presumably we'll update to the latest cspell eventually, so why not do that alone instead of doing it and also maintaining it in a separate list?

@alexander-akait alexander-akait merged commit 36987d4 into webpack-contrib:master Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants