Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bound control #1638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hicom150
Copy link
Contributor

@hicom150 hicom150 commented Aug 4, 2019

I've made a small refactor to simplify a bit the bound control code.

  • Delete unnecessary window state control
  • Check isMininized and isFullscreen before changing window size
  • Replace setContentBounds as useContentSize is enabled

@request-info
Copy link

request-info bot commented Aug 4, 2019

👋 We would appreciate it if you could provide us with more information about this issue.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Sep 13, 2022
@alxhotel alxhotel added accepted and removed stale labels Sep 13, 2022
}
function setBounds (bounds) {
// X and Y not specified? By default, center on current screen
if (bounds.x === null && bounds.y === null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bounds could still be null from the saved state of the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants