Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample module #272

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Add a sample module #272

merged 2 commits into from
Feb 23, 2022

Conversation

JakobMiksch
Copy link
Collaborator

@JakobMiksch JakobMiksch commented Jan 11, 2022

fixes #265

  • This PR adds a minimal module to app-starter that should help new users to create their custom modules.
  • This new SampleModule.vue is extensively commented to explain the basic anatomy of a module
  • It contains a simple access of the OpenLayers map to make creating custom map-related modules easier

image

@fschmenger
Copy link
Collaborator

Hi @JakobMiksch, this a first good step in the right direction!

Before you close #265, keep in mind, that we probably need some sort of API documentation for the module-cards. The available generic properties are at least documented on the app-conf level, so maybe this isn't urgent yet.
Also my point from the comment still stands, that we should factor out / separate the examples from the starter templates on the long run.
Maybe you could set up some further issues (1. reusable component doc, 2. app-starter example separation) from that or just keep #265 open?!

@JakobMiksch
Copy link
Collaborator Author

@fschmenger thanks for you comment. I agree with you that we should not forget about the other parts of #265

@JakobMiksch
Copy link
Collaborator Author

I created two new issue #274 and #275
Then #265 can be safely closed

@JakobMiksch JakobMiksch marked this pull request as draft February 2, 2022 08:23
@JakobMiksch JakobMiksch marked this pull request as ready for review February 14, 2022 13:26
Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Please merge.

@JakobMiksch JakobMiksch merged commit 0540935 into wegue-oss:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe how to add a custom module to Wegue
3 participants