Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpcli_all_the_way #625

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Wpcli_all_the_way #625

merged 3 commits into from
Jan 4, 2022

Conversation

alessandro-fazzi
Copy link
Member

@alessandro-fazzi alessandro-fazzi commented Jan 3, 2022

This is going to be merged into the 6.0 version branch.

This will bring a big feature: standing on the shoulder of the 6.0's mandatory peer dependency on wp-cli, we going to drop all the custom methods and configuration for the local environment relative to

  • db connection
  • db dump
  • db import
  • db adapt
  • wordmove site URL (former local.vhost config in movefile.yml)

All these actions and config will be done/get through wp-cli.

Now the only configuration we'll have for local environment will be

local:
  wordpress_path: /some/path

The goals of this feature are:

  • simplifying configuration
  • rely as much as possible on what wp-cli already can do

doctor command will still check for database config (user, password, etc.), erroring when actually we can't get those configs from wp-cli.

port and mysqldump_options and mysql_options and charset database configs are dropped: if you need to tweak around those, you'll need to do it the wordpress way (https://wordpress.org/support/article/editing-wp-config-php) and the wp-cli way (https://make.wordpress.org/cli/handbook/references/config/#config-files).

Last but not the least: this branch will update ruby language support to the current stable version 3.0.2.

Nonetheless the vision steering this feature was endorsed in #601 . I'm not taking all the ideas from @nlemoine , but I'm looking at what I can afford to bring out of alpha within my winter holidays ^^"

@alessandro-fazzi alessandro-fazzi self-assigned this Jan 3, 2022
The only needed one is `local.wordpress_path` now.

Other config are taken through - the now mandatory -
wp-cli.
@alessandro-fazzi
Copy link
Member Author

I've also updated the movefile.yml generator called by wordmove init command to reflect current changes

@alessandro-fazzi alessandro-fazzi merged commit 46e9ce9 into rewrite_for_6.0 Jan 4, 2022
@alessandro-fazzi alessandro-fazzi deleted the wpcli_all_the_way branch January 4, 2022 12:08
@nlemoine
Copy link
Contributor

nlemoine commented Jan 4, 2022

This is awesome! Thanks so much for implementing all these new features 😃 I just left a tiny comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants