-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to hs-bindgen-runtime
#355
Conversation
All modules now have prefix `HsBindgen.Runtime`. Module `HsBindgen.Runtime.Patterns` continues to re-export internal submodules.
7b13b17
to
1bc9678
Compare
I pushed prematurely. Sorry about that! The GitHub Actions configuration was created using a version of
The version in the old config is Success! Note: Work on this was delayed by a major GitHub incident. I took an early lunch. |
`HsBindgen.Runtime.Patterns` is removed, and sub-modules are now exposed as follows: * `HsBindgen.Runtime.Arithmetic` * `HsBindgen.Runtime.Backtrace` * `HsBindgen.Runtime.Enum.Bitfield` * `HsBindgen.Runtime.Enum.Simple`
I suspect this is haskell/cabal#10704 We have code in tests to find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we are done with shuffling code for some time now.
@phadej Your first review made a request for changes, so merging is blocked until you do another review. |
@TravisCardwell cant you just dismiss my review? Silly GitHub. I'm not approving any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read the whole patch, but GitHub is silly, after I request in some small part am I now obligated to review the whole thing? That's stupid, makes me not want to look at anything.
All modules now have prefix
HsBindgen.Runtime
. ModuleHsBindgen.Runtime.Patterns
continues to re-export internal submodules.