Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to hs-bindgen-runtime #355

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Rename to hs-bindgen-runtime #355

merged 4 commits into from
Jan 9, 2025

Conversation

TravisCardwell
Copy link
Collaborator

All modules now have prefix HsBindgen.Runtime. Module HsBindgen.Runtime.Patterns continues to re-export internal submodules.

All modules now have prefix `HsBindgen.Runtime`.  Module
`HsBindgen.Runtime.Patterns` continues to re-export internal submodules.
@TravisCardwell
Copy link
Collaborator Author

TravisCardwell commented Jan 9, 2025

I pushed prematurely. Sorry about that!

The GitHub Actions configuration was created using a version of haskell-ci that has not been released. I regenerated the config using a build of the current HEAD of main (3c811a19), but tests fail with the following error:

golden: user error (Cannot find package directory for hs-bindgen)

The version in the old config is 0.19.20240708, so I did a build using the previous commit (d6898d90). That resulted in version 0.19.20240702. I did a build using commit 5e5b27d7, which results in the target version. (It must be a time zone difference.)

Success!

Note: Work on this was delayed by a major GitHub incident. I took an early lunch.

`HsBindgen.Runtime.Patterns` is removed, and sub-modules are now exposed
as follows:

* `HsBindgen.Runtime.Arithmetic`
* `HsBindgen.Runtime.Backtrace`
* `HsBindgen.Runtime.Enum.Bitfield`
* `HsBindgen.Runtime.Enum.Simple`
@phadej
Copy link
Collaborator

phadej commented Jan 9, 2025

golden: user error (Cannot find package directory for hs-bindgen)

I suspect this is haskell/cabal#10704

We have code in tests to find hs-bindgen for our project structure (so cabal run golden works, not only cabal test); but haskell-ci makes different project structure and things break

@TravisCardwell TravisCardwell requested a review from phadej January 9, 2025 07:21
@phadej phadej removed their request for review January 9, 2025 07:40
Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we are done with shuffling code for some time now.

@TravisCardwell
Copy link
Collaborator Author

@phadej Your first review made a request for changes, so merging is blocked until you do another review.

@phadej
Copy link
Collaborator

phadej commented Jan 9, 2025

@TravisCardwell cant you just dismiss my review? Silly GitHub. I'm not approving any changes.

@phadej phadej self-requested a review January 9, 2025 07:57
Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the whole patch, but GitHub is silly, after I request in some small part am I now obligated to review the whole thing? That's stupid, makes me not want to look at anything.

@edsko edsko merged commit 69d1a02 into main Jan 9, 2025
10 checks passed
@edsko edsko deleted the rename-runtime branch January 9, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants