[add]:Import, export button for teachers and syllabus creation is improved #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a263d6. Added Subject Names to teacher page Added Subject Names to teacher page
1. Import button now checks for any matching record and overrides the content with the new data 2. on creation, the data already present is iterated and checked for any duplicate 3. data exported from auth teachers now doesn't have the created property 4. Added name validation which checks for presence of '.' and numbers 5.
note: the semesterData is initially set an object instead of it being undefined coz its causing an uncontrolled state
✅ Deploy Preview for attendo-admin ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mak626
requested changes
Apr 21, 2023
✅ Deploy Preview for attendo-admin-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mak626
requested changes
Apr 23, 2023
mak626
changed the title
…. data manipulation wont occur in those variables
mak626
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #30
close #35
@mak626 look into the syllabus creation. semester value by default while creation is 0