Update quirks for H5051, H5103, H5179.

[rhofour]

I believe this should fix #163, #188, and #206. It works locally for my H5179 devices.

[rhofour]

@wez Is there anything this is missing?

[cnewlandercvs]

@wez Is there anything this is missing?

Is this repo maintained anymore? Maybe just fork it and run with it until we learn otherwise. If this repo is indeed maintained we can switch back to it. Seems like this PR is addressing an issue three months old. And it's been over a week waiting for this PR to be merged.

[rhofour]

It's definitely still maintained. wez replied in #206 and pointed me in exactly the right direction to fix this.

If you want to test this out yourself you're welcome to switch over to https://github.com/rhofour/govee2mqtt/tree/h5179-fix and try it out. It would probably help if other people confirmed this fixed things for them.

[wez]

@cnewlandercvs In case you are not aware, you are coming across as supremely entitled when you make a comment like that. What I expect from folks that comment on my projects is to "be excellent to each other", and to keep comments focused and productive. Your comment is neither of those things; it demonstrates a lack of awareness of the nature of the current issues, prior conversations, or how open source works, while coming across with an entitled and impatient tone. I'd encourage you to not respond to this statement or try to defend what you said. Please simply hear me and hold your peace; you needn't say any more, because it will not be a productive outcome for anyone.

[wez]

@rhofour I think this looks good, thank you! I haven't gotten around to merging it yet because I've had a lot of real life family health concerns recently, and I'll need to refresh my memory on how to correctly cut and push a release for HAOS. Merging is the easy bit!

[fhk1407]

It's definitely still maintained. wez replied in #206 and pointed me in exactly the right direction to fix this.

If you want to test this out yourself you're welcome to switch over to https://github.com/rhofour/govee2mqtt/tree/h5179-fix and try it out. It would probably help if other people confirmed this fixed things for them.

Could you explain how to go about applying the fix to the HAOS add-on?

[alegend2k]

It's definitely still maintained. wez replied in #206 and pointed me in exactly the right direction to fix this.
If you want to test this out yourself you're welcome to switch over to https://github.com/rhofour/govee2mqtt/tree/h5179-fix and try it out. It would probably help if other people confirmed this fixed things for them.

Could you explain how to go about applying the fix to the HAOS add-on?

I also dont know how to use this in HASS - an explanation would be nice.

[amresnick]

If you want to test this out yourself you're welcome to switch over to https://github.com/rhofour/govee2mqtt/tree/h5179-fix

and try it out. It would probably help if other people confirmed this fixed things for them.

Could you explain how to go about applying the fix to the HAOS add-on?

I would also be interested in this (until @wez has time to make the actual release).

[alegend2k]

If you want to test this out yourself you're welcome to switch over to https://github.com/rhofour/govee2mqtt/tree/h5179-fix

and try it out. It would probably help if other people confirmed this fixed things for them.

Could you explain how to go about applying the fix to the HAOS add-on?

I would also be interested in this (until @wez has time to make the actual release).

but i cant add it to hass addon repository - if I try to add https://github.com/rhofour/govee2mqtt/tree/h5179-fix
erorr pops up

Cmd('git') failed due to: exit code(128) cmdline: git clone -v --recursive --depth=1 --shallow-submodules -- https://github.com/rhofour/govee2mqtt/tree/h5179-fix /data/addons/git/c84125d4 stderr: 'Cloning into '/data/addons/git/c84125d4'... fatal: repository 'https://github.com/rhofour/govee2mqtt/tree/h5179-fix/' not found '

[wez]

Thanks @rhofour!

[rhofour]

Thanks for merging and releasing this! I can see that all my sensors are now working as expected.

[alegend2k]

Great it is working now !! One question though - is it possible to add an offset to the sensor value ?

[buschtoens]

@alegend2k AFAIK it's not directly possible in the addon itself, but you could use a template helper instead.

For instance, here's the template helper I've been using to convert the incorrect Fahrenheit readings to Celsius:

{% set t = states('sensor.govee_temperature') | float %}
{{ (t * 100 - 32) * (5/9) | round(1, default=0) }}

[fhk1407]

Thanks for merging and releasing this! I can see that all my sensors are now working as expected.

I'm still not being served an updated add-on... I would be grateful for an explanation on how to get it to work?

[cgoudie]

Looks like this would fix #247

[Marshall-Hallenbeck]

Hmm this was merged but it still seems like it's reporting wrong for me.

[amresnick]

I don't think a build was ever released after the merge was made.

…

On Mon, Sep 2, 2024, 15:09 Marshall Hallenbeck ***@***.***> wrote: Hmm this was merged but it still seems like it's reporting wrong for me. — Reply to this email directly, view it on GitHub <#232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMVXGE5V4UBY4EST7R2VDLZUTO3FAVCNFSM6AAAAABJ24W7JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGMZTOOBUHE> . You are receiving this because you commented.Message ID: ***@***.***>

[Marshall-Hallenbeck]

Shouldn't adding the repo just use the newest code, or does it download the newest release instead?

[amresnick]

I'm not sure what happens if you're manually installing the repo in HA. If you're installing it through the HA Add-Ons, it will install the latest build, not the latest commit. The repo owner needs to build a new release for these changes to come to us.

…

On Mon, Sep 2, 2024, 15:33 Marshall Hallenbeck ***@***.***> wrote: Shouldn't adding the repo just use the newest code, or does it download the newest release instead? — Reply to this email directly, view it on GitHub <#232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMVXGE7CJZDBXSDHIXDWYDZUTRUPAVCNFSM6AAAAABJ24W7JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGM2TAMZQGM> . You are receiving this because you commented.Message ID: ***@***.***>

[rhofour]

Shouldn't adding the repo just use the newest code, or does it download the newest release instead?

I believe it only downloads the newest release, but there was a release on July 13th that included this: https://github.com/wez/govee2mqtt/releases/tag/2024.07.13-82ddc6e9

I have no idea why it seems some people aren't seeing it, but I was able to update through HA Add-Ons.